fix(installer): never overwrite JSONC agent configs on parse failure#6
Merged
Conversation
The installer parsed agent config files with plain serde_json, so a config containing JSONC comments (// or /* */) which are valid for opencode, Cursor and others failed to parse. The reader returned an empty object, which the write path persisted, destroying the user's entire config (providers, other MCP servers, permissions) and leaving only the codegraph stub. Add a JSONC-tolerant parser (comment stripping with string-literal awareness, trailing-comma tolerance) and a ConfigRead Missing/Parsed/Unparseable outcome. Every target write path now aborts on an existing-but-unparseable file (reported as Skipped, original left untouched and backed up) instead of clobbering it. Read-only detection paths stay lenient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codegraph installdestroyed users' agent config files when the config was JSONC (contained//or/* */comments, valid for opencode, Cursor, and others). serde_json failed to parse, the reader returned an empty object, and the write path persisted it, replacing the user's entire config (providers, other MCP servers, permissions) with a codegraph-only stub.Fix
Verification